Skip to content

custom event metadata from buckconfig#1299

Closed
KlotzAndrew wants to merge 1 commit into
facebook:mainfrom
KlotzAndrew:feature/add_custom_metadata_to_events
Closed

custom event metadata from buckconfig#1299
KlotzAndrew wants to merge 1 commit into
facebook:mainfrom
KlotzAndrew:feature/add_custom_metadata_to_events

Conversation

@KlotzAndrew

@KlotzAndrew KlotzAndrew commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

metadata.rs current has a number of metadata fields added to buck2 log events, these are hardcoded and some are specific to meta. This change supports adding arbitrary metadata to buck2 event uploads, for any user to configure though their .buckconfig:

  • key/values are arbitrary strings
  • suports $ENV_VAR subsitution
  • supports $(config section.key) directive for following for .buckconfig and .buckconfig.local
  • config is loaded at daemon start, so restarts required to pickup changes

Example

.buckconfig

[buck2_metadata]
key = value
env_var = $ENV_VAR

meant to be paired with something like this to upload logs: #1296

dont modify pool.rs

cleanup
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 20, 2026
@meta-codesync

meta-codesync Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D101692996. (Because this pull request was imported automatically, there will not be any future comments.)

@meta-codesync meta-codesync Bot closed this in bc6023f Jun 30, 2026
@meta-codesync meta-codesync Bot added the Merged label Jun 30, 2026
@meta-codesync

meta-codesync Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@scottcao merged this pull request in bc6023f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant